Make and and or return type NonNullable
#191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Techn1x
reviewed
Sep 4, 2023
Comment on lines
-15
to
+16
| @andArg={{or (hash) (array)}} | ||
| @orArg={{and (hash) (array)}} | ||
| @andArg={{or this.objectOrUndefined this.arrayOrUndefined}} | ||
| @orArg={{and this.objectOrUndefined this.arrayOrUndefined}} |
There was a problem hiding this comment.
I don't quite understand the test but, are these the wrong way around?
There was a problem hiding this comment.
yeah, this test case needs updates to better reflect use real world scenarios.
Will do the same prob after #196
Techn1x
reviewed
Sep 4, 2023
| return new Date().getMonth() === 7 ? { foo: 'bar' } : undefined; | ||
| } | ||
|
|
||
| get arrayOrUndefined(): object | undefined { |
There was a problem hiding this comment.
this isn't an array 😅
There was a problem hiding this comment.
yeap! it is. I had a huge doubts about this approach in the first place and more I think about it, the more I get confident this is totally wrong.
I think #196 if the way to go (just need to make CI happy)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.