Add more tweaks to CQ customizer #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main tweaks here are how the incoming params are pressed in the browser, and that all seems to be working
Though I seeming the have trouble with the variables themselves, as in no matter how I change the variable values, either in the script or the customizer the model doesn't change
I also noticed that if I specify a parameter that doesn't exist in the script than it throws with
cadquery.cqgi.InvalidParameterError: Cannot set value 'aString': not a parameter of the model.this seems like a problem to me as this will happen when ever the user comments out a variable as the customizer UI wont update to remove that variable until after the next render. I think it would be better if extra params are just ignored, that's how they're handled in JSCAD and OpenSCAD.