-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for statsd gauge bucket in statsd output writer #44
Comments
Thanks @NGough34, you are right, I don't see any reason why we could not support GAUGE as well. Can you submit a PR? |
jmxtrans-agent-1.2.4.jar still return all mbean attributes as counters, eg: 'java.lang:type=OperatingSystem' mbean 'ProcessCpuLoad' attribute is of Type 'double' and it should be metricType 'gauge'. Is there a way to configure this in existing jmxtrans-agent version? |
Found answer to this. Need to add "type" property along with mbean query, eg: Might be good to add to documentation/configuration examples. |
Hi @mindkir, feel free to submit a pr for a doc fix. I am sure @cyrille-leclerc would appreciate that. |
Better documentation for #44 and @mindkir 's #44 (comment)
Statsd allows for collection of stats in a few different data types: https://github.com/etsy/statsd/blob/master/docs/metric_types.md
I propose adding a bucketType field to the statsd output writer to allow configuring these different types of buckets - particularly the GAUGE type.
Is there any reason this hasn't been implemented? I can see in the code it is hardcoded to COUNT type. One issue I foresee is you inherently have the same bucketType for all queries, which will likely not be the case ie. you are collecting gauges and times but you've configured your output for a gauge.
I have implemented and semi-tested the GAUGE type so far.
The text was updated successfully, but these errors were encountered: