Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cucumber gherkin to v12 #224

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

jayzz55
Copy link

@jayzz55 jayzz55 commented Apr 1, 2020

gherkin-ruby released v12 here: https://github.com/cucumber/gherkin-ruby/releases/tag/v12.0.0

this commit is to update dependency to use the latest version of
cucumber gherkin.

@jayzz55 jayzz55 force-pushed the upgrade-cucumber-gherkin-to-v12 branch from 21a4bf9 to 019611c Compare April 1, 2020 00:12
@jayzz55 jayzz55 changed the title Upgrade cucumber gherkin to v12 WIP - Upgrade cucumber gherkin to v12 Apr 1, 2020
@jayzz55
Copy link
Author

jayzz55 commented Apr 1, 2020

The CI build is failing on uninitialized constant Pry::Command::ExitAll for ruby with version 2.3.6

Seems that zeitwerk latest version stopped supporting ruby version 2.3.6

@gongo
Copy link
Collaborator

gongo commented Apr 1, 2020

Hi @jayzz55

I have removed 2.3 and 2.4 from `.travis.yml. (Both were EOL)

#225

gherkin-ruby released v12 here: https://github.com/cucumber/gherkin-ruby/releases/tag/v12.0.0

this commit is to update dependency to use the latest version of
cucumber gherkin.
@jayzz55 jayzz55 force-pushed the upgrade-cucumber-gherkin-to-v12 branch from ff21a35 to 68397b4 Compare April 1, 2020 05:41
@jayzz55
Copy link
Author

jayzz55 commented Apr 1, 2020

Sweet, thank you @gongo :-)

@jayzz55 jayzz55 changed the title WIP - Upgrade cucumber gherkin to v12 Upgrade cucumber gherkin to v12 Apr 1, 2020
@gongo
Copy link
Collaborator

gongo commented Apr 1, 2020

Thanks!

@gongo gongo merged commit 1660e6f into jnicklas:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants