Update libffi to 3.4.4 #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
headius
force-pushed
the
libffi-3.4.4
branch
11 times, most recently
from
967edc7
to
189d78b
Compare
headius
force-pushed
the
libffi-3.4.4
branch
from
189d78b
to
f6836ee
Compare
|
This will need another look; the new libffi appears to add more hard dependencies on newer glibc, as discovered by @richardstartin in #138 (comment). It would be worth us adding some kind of test that confirms we have not introduced dependencies on too-new glibc. We also could revisit making it possible to also include binaries that differ by Linux flavor and version, but that's a lot more work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may help fix #138 if the new trampoline code for closures eliminates the dependency on
memfd_create.