Revert "(fix) Fix import map overrides panel (openmrs#523)" (openmrs#541

) This reverts commit c69f1d7. Loading the import map overrides script from a CDN violates dev3's CSP policy leading problems loading the app. So for now, we're shelving this approach and looking for a more viable solution.
jnsereko · Oct 5, 2022 · 622dd75 · 622dd75
1 parent b8a431f
commit 622dd75
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/packages/apps/esm-devtools-app/src/devtools/import-map.component.tsx b/packages/apps/esm-devtools-app/src/devtools/import-map.component.tsx
@@ -1,7 +1,7 @@
 import React, { useRef, useEffect } from "react";
 import styles from "./import-map.styles.css";
 
-export default function ImportMap({ toggleOverridden }: ImportMapProps) {
+export default function ImportMap(props: ImportMapProps) {
   const importMapListRef = useRef<HTMLElement>(null);
 
   useEffect(() => {
@@ -16,7 +16,7 @@ export default function ImportMap({ toggleOverridden }: ImportMapProps) {
       );
 
     function handleImportMapChange(evt) {
-      toggleOverridden(importMapOverridden());
+      props.toggleOverridden(importMapOverridden());
     }
   }, [importMapListRef.current]);
 

diff --git a/packages/shell/esm-app-shell/src/index.ejs b/packages/shell/esm-app-shell/src/index.ejs
@@ -26,10 +26,6 @@
     >
     <script type="systemjs-importmap" src="<%= openmrsImportmapUrl %>"></script>
 <% } %>
-    <script
-    type="text/javascript"
-    src="https://cdn.jsdelivr.net/npm/import-map-overrides/dist/import-map-overrides.js"
-    ></script>
   </head>
   <body>
     <%= htmlWebpackPlugin.tags.bodyTags %>

diff --git a/packages/shell/esm-app-shell/src/run.ts b/packages/shell/esm-app-shell/src/run.ts
@@ -1,3 +1,4 @@
+import "import-map-overrides";
 import "systemjs/dist/system";
 import "systemjs/dist/extras/amd";
 import "systemjs/dist/extras/named-exports";