close #54: Make sure all commands return a value of the type int #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emerson Jair <emersonjairr@gmail.com>
|
closing in favour of #56 |
|
Sorry for the lack of response. This completely fell off my radar. What's your thinking behind closing this in favour of locking the versions? Returning an int from every command doesn't seem like a big deal, and if older versions of Symfony ignore it, then it's an easy way to make it compatible with the various major versions. We're going to have to support Symfony 4 at some point (well, unless d.org does pull requests by then and makes this tool obsolete, which it looks like it might), so this fix seems more future-proof. |
|
True that, I think #56 was more "safe" from my side as I do not have the full knowledge of the code. I am not 100% sure all the return values are correct on this PR as I haven't tested them all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #54