Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add deployment job to workflow #329

Merged
merged 4 commits into from
Mar 30, 2024

Conversation

deandreamatias
Copy link
Contributor

@deandreamatias deandreamatias commented Sep 17, 2022

Close: #198

  • Upgrade github actions versions
  • Remove unnecessary comments
  • Add check publish warnings job to workflow
  • Add deployment job to workflow

⚠️ @joanpablo to this pipeline works, need two thinks:

  • Get the enviroment PUB_DEV_PUBLISH_ACCESS_TOKEN and PUB_DEV_PUBLISH_REFRESH_TOKEN
  • To add the token to repository, go to Settings > Actions > Press on New repository secret
    Is not a enviroment secret, is a repository secret

This an image that my configuration for flutter_form_builder
Your token will be configure below repository secrets, because is a single repository and no an organization

image

@mdeandrea-mrmilu
Copy link

Hi @vasilich6107 and @kuhnroyal please can take a look in this PR and this comment? Thanks

@mdeandrea-mrmilu
Copy link

Hi @joanpablo
Could you review this PR?

@joanpablo
Copy link
Owner

Thanks, @mdeandrea-mrmilu.

So as far as I understand this deployment will only be triggered if a Tag is created, and not when simply pushing changes to master or develop. Could you confirm that, please?

@deandreamatias
Copy link
Contributor Author

Yes, I confirm this, only with tag created.
Today, after sent this comment, I watch this video about automatic deploy of packages. Maybe is a way more secure and improved that this code change

@joanpablo
Copy link
Owner

Oh, thanks for sharing the video @deandreamatias I will see it, and let you know my comments about it.

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.01%. Comparing base (40d917b) to head (c9ae435).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #329   +/-   ##
========================================
  Coverage    95.01%   95.01%           
========================================
  Files           67       67           
  Lines         1385     1385           
========================================
  Hits          1316     1316           
  Misses          69       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deandreamatias
Copy link
Contributor Author

@joanpablo branch updated!

@joanpablo joanpablo merged commit 1a3c954 into joanpablo:develop Mar 30, 2024
8 checks passed
@deandreamatias deandreamatias deleted the feature/198 branch March 30, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants