Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document parallel_config #1451

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

GaelVaroquaux
Copy link
Member

It seems that parallel_config was not very visible in the docs.

This is a quick fix to improve a bit the situation.

We should probably adapt more our docs, but I only have a little bit of time.

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.10 ⚠️

Comparison is base (f6aaaa6) 94.88% compared to head (b7c8b81) 94.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1451      +/-   ##
==========================================
- Coverage   94.88%   94.78%   -0.10%     
==========================================
  Files          44       44              
  Lines        7366     7366              
==========================================
- Hits         6989     6982       -7     
- Misses        377      384       +7     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tomMoral
Copy link
Contributor

the failing doc build should be fixed by #1456
could you retriever the build?

@GaelVaroquaux GaelVaroquaux merged commit 9f7edc2 into joblib:master Jun 21, 2023
@GaelVaroquaux
Copy link
Member Author

the failing doc build should be fixed by #1456 could you retriever the build?

Sorry, I made a mistake with the web interface trying to merge main in this PR, and did the opposite. I hope that it is fine.

1 similar comment
@GaelVaroquaux
Copy link
Member Author

the failing doc build should be fixed by #1456 could you retriever the build?

Sorry, I made a mistake with the web interface trying to merge main in this PR, and did the opposite. I hope that it is fine.

@tomMoral
Copy link
Contributor

It is okay, the CI is green and the change looked okay.
I just wanted to have a look at the rendering before merging but we can still improve the doc later on if needed, so no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants