ENH enable faulthandler traceback reporting on worker crash by SIGSEV #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
commented
Aug 1, 2024
| if faulthandler.is_enabled(): | ||
| # Fault handler is already enabled, possibly via a custom | ||
| # initializer to customize the behavior. | ||
| mp.util.debug("faulthandler already enabled.") |
There was a problem hiding this comment.
This should be covered by "Case 4" in the test but this it detected by the coverage module because we use subprocess.Popen in this test to get a full control on the env and ability to inspect stderr in isolation of pytest.
… variability (PyPy)
|
The pypy build deadlocked on commit 9d868e7 before reaching the new |
|
The pypy deadlock is probably unrelated to this PR, but let's push on more time to make sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically call
faulthandler.enable()by default to dump extra debug info to crashed workers' stderr, typically on SIGSEV, SIGBUS and co.I also expanded the error message of
TerminatedWorkerErrorto point the users to look at stderr for more details. This should help us debug stability problems on our CI but also assist our users and interact more productively with them when they report problems.