Skip to content

Commit

Permalink
Remove defining inline for MVSC because no longer necessary
Browse files Browse the repository at this point in the history
  • Loading branch information
jobovy committed Jun 24, 2024
1 parent d7b46ff commit d49442a
Showing 1 changed file with 0 additions and 14 deletions.
14 changes: 0 additions & 14 deletions setup.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import distutils.ccompiler
import glob
import os
import os.path
Expand Down Expand Up @@ -111,19 +110,6 @@
# HACK for testing
# gsl_version= ['0','0']

# MSVC: inline does not exist (not C99!); default = not necessarily actual, but will have to do for now...
# Note for the futureL could now get the actual compiler in the BuildExt class
# below
if distutils.ccompiler.get_default_compiler().lower() == "msvc":
extra_compile_args.append("-Dinline=__inline")
# only msvc compiler can be tested with initialize(), msvc is a default on windows
# check for 'msvc' not WIN32, user can use other compiler like 'mingw32', in such case compiler exists for them
try:
test_compiler = distutils.ccompiler.new_compiler()
test_compiler.initialize() # try to initialize a test compiler to see if compiler presented
except PlatformError: # this error will be raised if no compiler in the system
no_compiler = True

# To properly export GSL symbols on Windows, need to defined GSL_DLL and WIN32
if WIN32:
extra_compile_args.append("-DGSL_DLL")
Expand Down

0 comments on commit d49442a

Please sign in to comment.