Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.11 support #503

Merged
merged 48 commits into from
May 3, 2023
Merged

Add Python 3.11 support #503

merged 48 commits into from
May 3, 2023

Conversation

jobovy
Copy link
Owner

@jobovy jobovy commented Sep 1, 2022

Note that the latest galpy release already includes Python 3.11 wheels; this issue just tracks progress to fully changing the build/test infrastructure to Python 3.11

This PR tracks progress towards fully supporting Python 3.11 (expected Oct 3 2022). Any necessary fixes will be done separately outside of this PR, so actual Python 3.11 support can be achieved for many platforms before achieving it for all.

Current status:

  • Linux works, but can't run tests dependent on JAX or numba, because they do not support Python 3.11 yet. This affects only the spherical DFs (for JAX) and the non-inertial-frame force tests
    • Test JAX-dependent code
    • Test numba-dependent code
  • Mac works, at least the orbit tests that we run in the CI
  • Windows untested, because Windows tests use conda in the CI and conda does not support Python 3.11 yet.
    • Run Windows tests
    • Update appveyor tests as well
  • Wheels:
    • Build Python 3.11 wheels for all platforms

@jobovy jobovy added this to the v1.9 milestone Sep 1, 2022
@jobovy jobovy self-assigned this Sep 1, 2022
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (f12e009) 99.92% compared to head (dda753f) 99.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #503      +/-   ##
==========================================
- Coverage   99.92%   99.91%   -0.01%     
==========================================
  Files         196      196              
  Lines       28886    28886              
==========================================
- Hits        28863    28862       -1     
- Misses         23       24       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jobovy jobovy marked this pull request as ready for review May 2, 2023 17:46
@jobovy jobovy merged commit db768c6 into main May 3, 2023
97 of 98 checks passed
@jobovy jobovy deleted the py311 branch May 3, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant