Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error when plotting a potential with both xy=True and effective=True #587

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

jobovy
Copy link
Owner

@jobovy jobovy commented Jun 21, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6928fe8) 99.91% compared to head (de286ea) 99.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #587   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         198      198           
  Lines       29157    29161    +4     
=======================================
+ Hits        29133    29137    +4     
  Misses         24       24           
Impacted Files Coverage Δ
galpy/potential/Potential.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jobovy jobovy merged commit a209b51 into main Jun 21, 2023
@jobovy jobovy deleted the fix572 branch June 21, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plotPotentials and Potential.plot: cannot use effective and xy at the same time
1 participant