Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenMP support to Mac builds and wheels #660

Merged
merged 7 commits into from
Jul 4, 2024
Merged

Add OpenMP support to Mac builds and wheels #660

merged 7 commits into from
Jul 4, 2024

Conversation

jobovy
Copy link
Owner

@jobovy jobovy commented Jul 2, 2024

No description provided.

@jobovy jobovy added this to the v1.10 milestone Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.91%. Comparing base (1e3bcd3) to head (fa740c5).
Report is 22 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #660   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         200      200           
  Lines       29260    29269    +9     
  Branches      563      563           
=======================================
+ Hits        29234    29243    +9     
  Misses         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jobovy jobovy force-pushed the mac-openmp branch 3 times, most recently from a307b4f to d1efc1e Compare July 3, 2024 01:13
…penMP runtimes that occurs in conda environments containing numpy and pip-installed galpy
@jobovy jobovy merged commit 04e3b5f into main Jul 4, 2024
90 checks passed
@jobovy jobovy deleted the mac-openmp branch July 4, 2024 17:23
@jobovy
Copy link
Owner Author

jobovy commented Jul 4, 2024

Difficult to avoid the issue with combining conda-numpy and pip-galpy, so approach taken here is to detect and warn about the issue, falling back on non-C version of galpy.

Supersedes and thus closes #651.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant