[reek] change config to ignore some pain points #1
Conversation
|
As seen together, UtilityFunction can be annoying as well in an iterator, cf troessner/reek#681 |
| MissingSafeMethod: | ||
| enabled: true | ||
| enabled: false |
There was a problem hiding this comment.
bang means that the method is the dangerous version and that a safe version exist.
bang mean that there is a preferable and less dangerous version of the method.
Instead of remove this metric, just stop to use bang.
concat is a good example in ruby. It modify the receiver like map! or other methods with bang.
It is name concat and not concat!. There is not link between the modification of the receiver and the bang.
https://www.rubydoc.info/github/troessner/reek/Reek/Smells/PrimaDonnaMethod
There was a problem hiding this comment.
I know but this is not followed at all in our codebase. It currently makes noise everywhere.
| public_methods_only: false |
There was a problem hiding this comment.
There is no change here. Do you want to change to public_methods_only: true?
It may be acceptable but I think we often use functional method that could be extract in a module.
For example, it is preferable to extract method that serialize or build an object because it is a specific responsibility.
UtilityFunction shows that there is a mix of responsibilities.
There was a problem hiding this comment.
Well, this one is not working properly. e.g Using a map on an instance variable and then using a method inside will trigger this cop. There is an issue open for a while on reek repository for that but currently this is a major bug IMO (check alice link above).
No description provided.