Add complete block duration

Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott · Apr 29, 2021 · 021a9b4 · 021a9b4
1 parent 4900314
commit 021a9b4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/modules/ingester/flush.go b/modules/ingester/flush.go
@@ -214,13 +214,15 @@ func (i *Ingester) handleComplete(op *flushOp) (retry bool, err error) {
 		return false, nil
 	}
 
-	level.Debug(log.Logger).Log("msg", "completing block", "userid", op.userID)
+	start := time.Now()
+	level.Info(log.Logger).Log("msg", "completing block", "userid", op.userID, "blockID", op.blockID)
 	instance, err := i.getOrCreateInstance(op.userID)
 	if err != nil {
 		return false, err
 	}
 
 	err = instance.CompleteBlock(op.blockID)
+	level.Info(log.Logger).Log("msg", "block completed", "userid", op.userID, "blockID", op.blockID, "duration", time.Since(start))
 	if err != nil {
 		handleFailedOp(op, err)
 

diff --git a/tempodb/encoding/appender_buffered.go b/tempodb/encoding/appender_buffered.go
@@ -75,6 +75,7 @@ func (a *bufferedAppender) RecordsForID(id common.ID) []common.Record {
 	for bytes.Equal(a.records[i].ID, id) {
 		sliceRecords = append(sliceRecords, a.records[i])
 
+		i++
 		if i >= len(a.records) {
 			break
 		}

diff --git a/tempodb/encoding/appender_record.go b/tempodb/encoding/appender_record.go
@@ -37,6 +37,7 @@ func (a *recordAppender) RecordsForID(id common.ID) []common.Record {
 	for bytes.Equal(a.records[i].ID, id) {
 		sliceRecords = append(sliceRecords, a.records[i])
 
+		i++
 		if i >= len(a.records) {
 			break
 		}