Fix error with no close button

joeattardi · May 18, 2022 · eadfeff · eadfeff
1 parent c6a77cb
commit eadfeff
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 11 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,12 @@
 
 For full details, see the documentation at [https://picmojs.com](https://picmojs.com).
 
+## [5.0.1] - 2022-05-18
+
+### Changed
+
+- Fixed exception being thrown when opening a popup picker with `showCloseButton: false` set.
+
 ## [5.0.0] - 2022-05-15
 
 First PicMo release (previously Emoji Button).

diff --git a/packages/popup-picker/src/popupPicker.ts b/packages/popup-picker/src/popupPicker.ts
@@ -237,17 +237,19 @@ export class PopupPickerController {
   }
 
   private animateCloseButton(openState: boolean) {
-    return animate(this.closeButton, {
-      opacity: [0, 1]
-    },
-    {
-      duration: 25,
-      id: openState ? 'show-close' : 'hide-close',
-      easing: 'ease-in-out',
-      direction: openState ? 'normal' : 'reverse',
-      fill: 'both',
-    },
-    this.options)
+    if (this.closeButton) {
+      return animate(this.closeButton, {
+        opacity: [0, 1]
+      },
+      {
+        duration: 25,
+        id: openState ? 'show-close' : 'hide-close',
+        easing: 'ease-in-out',
+        direction: openState ? 'normal' : 'reverse',
+        fill: 'both',
+      },
+      this.options);
+    }
   }
 
   /**