Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about JDK6 on OS X #127

Merged
merged 1 commit into from
Jun 16, 2014
Merged

Add note about JDK6 on OS X #127

merged 1 commit into from
Jun 16, 2014

Conversation

TheSpyder
Copy link
Contributor

As discussed in issue #90. Regardless of how it is compiled, at runtime using JNI on OS X requires Java 6.

joeferner added a commit that referenced this pull request Jun 16, 2014
@joeferner joeferner merged commit e3c82f0 into joeferner:master Jun 16, 2014
@jsdevel
Copy link
Collaborator

jsdevel commented Jun 16, 2014

@TheSpyder I'm able to compile on OS X when my java home references 1.7. Are you saying that 1.6 must be installed as well? I'm not sure this PR was accurate because of that.

@TheSpyder
Copy link
Contributor Author

I guess it wouldn't make much sense unless you read the comment I linked to in the readme. Sorry :)

While you can compile using JDK7 quite happily with the changes made in 0.3.4, at runtime the OS forces the use of JDK6. It's actually an Oracle JDK bug. You can test this by deleting (or moving) /System/Library/Java/JavaVirtualMachines/1.6.0.jdk and then running an app that uses node-java. The system will prompt you to install Java 6 regardless of how node-java is compiled (unless you use the workarounds I mention in the comment).

@TheSpyder TheSpyder deleted the osx-readme branch June 17, 2014 00:04
@jsdevel
Copy link
Collaborator

jsdevel commented Jun 17, 2014

Thanks for the clarification @TheSpyder. If that's the case, then i think the README should be updated to say that jdk6 is required at runtime.

@jsdevel
Copy link
Collaborator

jsdevel commented Jun 17, 2014

@TheSpyder there were a lot of comments listed in #90. Can you recap here on how we can reproduce the issue? Would removing JDK6 from my system recreate the issue for me?

@TheSpyder
Copy link
Contributor Author

There were a lot of comments, but the readme link I added specifically navigates to to my big comment explaining my research rather than the issue in general.

If you remove the folder I mentioned above you can reproduce the issue.

Given that JDK6 is required at runtime, I'm not sure there is much point in supporting other versions of Java for installation - but that's your call :)

@jsdevel
Copy link
Collaborator

jsdevel commented Jun 17, 2014

Thanks @TheSpyder. I updated the README and added a separate section for OSX users. Thanks again for your help!

@TheSpyder
Copy link
Contributor Author

Cool. You misspelt installation though :)

@jsdevel
Copy link
Collaborator

jsdevel commented Jun 17, 2014

0c23c77 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants