Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

Commit

Permalink
Guard Against Null Go
Browse files Browse the repository at this point in the history
  • Loading branch information
joefitzgerald committed Dec 13, 2014
1 parent 1ba5d8c commit 9555fbd
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## v3.0.9 (December 12, 2014)

* :bug: Fix potential race condition

## v3.0.8 (December 12, 2104)

* :bug: Fix integration with autocomplete-plus (fixes #101)
Expand Down
7 changes: 4 additions & 3 deletions lib/goexecutable.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,13 @@ class GoExecutable
async.series([
(callback) =>
done = (exitcode, stdout, stderr) =>
console.log exitcode
unless stderr? and stderr isnt ''
if stdout? and stdout isnt ''
components = stdout.replace(/\r?\n|\r/g, '').split(' ')
go.name = components[2] + ' ' + components[3]
go.version = components[2]
go.env = @env
go?.name = components[2] + ' ' + components[3]
go?.version = components[2]
go?.env = @env
console.log 'Error running go version: ' + err if err?
console.log 'Error detail: ' + stderr if stderr? and stderr isnt ''
callback(null)
Expand Down

2 comments on commit 9555fbd

@aarongreenlee
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No release notes for 3.0.10 or 3.0.11?

@joefitzgerald
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm switching to Github Releases for the changelog, instead of using CHANGELOG.md; I just haven't got around to actually doing the migration.

Please sign in to comment.