Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

Does go-plus support build tags? #573

Closed
ian-kent opened this issue Feb 19, 2017 · 8 comments
Closed

Does go-plus support build tags? #573

ian-kent opened this issue Feb 19, 2017 · 8 comments

Comments

@ian-kent
Copy link

ian-kent commented Feb 19, 2017

I've read the FAQ and searched issues, but can't find any info about it.

My build requires a build tag, e.g. go build -tags 'production' to compile successfully, is there a way to have go-plus do this for me?

At the moment I always have 1 issue in the status bar with an error of no buildable Go source files in ...

Not a major problem if it's not supported, just wanted to make sure I haven't missed anything!

edit: p.s., thanks, go-plus is an incredibly incredibly useful plugin!

@zmb3
Copy link
Collaborator

zmb3 commented Feb 21, 2017

Not currently supported, but high in priority. Stay tuned!

@zmb3
Copy link
Collaborator

zmb3 commented Mar 26, 2017

Consider adding separate tags for build/guru (see #603).

@akutz
Copy link

akutz commented May 2, 2017

Hi @zmb3,

This is becoming more and more an important issue for me. I heavily rely on tags for projects REX-Ray and libStorage, and I need to be able to activate certain build configurations in Atom.

Thank you for the awesome plug-in!

@freman
Copy link

freman commented Aug 1, 2017

I'd love to see this in the test config too

In fact, if I could just globally configure -tags testing that'd satisfy me :D

@igorsimjanoski
Copy link

Hi, tnx for the awesome plugin, but this problem seems like showstopper when using go-plus on Windows, at least in our use-case.

For example, we're using go-plus to develop hyperledger chaincode but build fails because in order to build fabric dependencies you need to specify: -tags nopkcs11

Of course we can move to other platforms but some developers wants to work on windows...

Is there any plan for fixing this issue?

Thanks.

@zmb3
Copy link
Collaborator

zmb3 commented Jan 8, 2018

There is an old branch that took the simple approach of adding a global config option for build tags. Would that help you here? I can see about merging that functionality.

@igorsimjanoski
Copy link

I think yes, if merging isn't complicated i can give it a try after you merge the functionality.

Thanks.

zmb3 added a commit that referenced this issue Jan 15, 2018
Introduce `go-plus.config.additional{Build|Test}Args` config properties that allow users to alter the flags that are passed to:

build args:
- go build / go install
- go test -c

test args:
- go test -coverprofile

This can be used to define build tags, for example.

- Fixes #282
- Fixes #308
- Fixes #551
- Fixes #573
- Closes #565
@zmb3
Copy link
Collaborator

zmb3 commented Jan 15, 2018

Thanks for your patience with this, folks. I just opened #735 which will allow you to add custom args for your build tags. For example -tags "tag1 tag2".

I expect this to be merged and released within a week or so.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants