This repository has been archived by the owner on May 7, 2021. It is now read-only.
Better godef integration: local defs, imports #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go-plus' current godef integration is limited to top-level and exported names,
and does not work for method calls:
buf := bytes.Buffer{}
buf.Write([]byte{0x0}) // godef on Write and buf didn't work.
This is because godef was being run as:
godef -f filebeingedited.go buf.Write
which doesn't give godef enough context to know what "buf" and "Write" are.
The fix is to run godef with the offset (-o) option to give it the offset
in the file where the cursor is, and let godef figure out what the user's
trying to navigate to.
This commit also keeps track of godef navigation on a stack and allows going
back to previous locations where godef was triggered with the godef-return
command.
|
LGTM. Thanks, this is great! |
joefitzgerald
added a commit
that referenced
this pull request
Aug 24, 2015
Better godef integration: local defs, imports
| @@ -3,4 +3,6 @@ | |||
| 'atom-text-editor[data-grammar="source go"]:not(.mini)': | |||
| 'ctrl-alt-c': 'golang:gocover' | |||
| 'ctrl-alt-shift-c': 'golang:cleargocover' | |||
| # Shouldn't these be ctrl-alt for portability? | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-plus' current godef integration is limited to top-level and exported names,
and does not work for method calls:
This is because godef was being run as:
which doesn't give godef enough context to know what "buf" and "Write" are.
The fix is to run godef with the offset (-o) option to give it the offset
in the file where the cursor is, and let godef figure out what the user's
trying to navigate to.
This commit also keeps track of godef navigation on a stack and allows going
back to previous locations where godef was triggered with the godef-return
command.