Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add godoc examples #33

Merged
merged 2 commits into from
Jan 6, 2022
Merged

Add godoc examples #33

merged 2 commits into from
Jan 6, 2022

Conversation

joeig
Copy link
Owner

@joeig joeig commented Jan 6, 2022

  • Does your submission pass all tests against mocks? make test
  • Does your submission pass all tests against a real instance running PowerDNS Authoritative Server 4.1, 4.2 and 4.3? docker-compose -f docker-compose-v4.3.yml up && make test-without-mocks
  • Do your tests meet or exceed the coverage results of the master branch? make coverage && go tool cover -html=c.out
  • Does your submission pass the format guidelines? make check-fmt

Furthermore, the pipeline performs additional checks against your submission:

  • Does your submission comply with common best practices? golangci-lint run && staticcheck ./...

@joeig joeig self-assigned this Jan 6, 2022
@joeig joeig merged commit 8313b10 into master Jan 6, 2022
@joeig joeig deleted the readme branch January 6, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant