Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TSIGKeys API #70

Merged
merged 3 commits into from
Dec 30, 2023
Merged

Add TSIGKeys API #70

merged 3 commits into from
Dec 30, 2023

Conversation

Avarei
Copy link
Contributor

@Avarei Avarei commented Dec 22, 2023

implements #69.

First time writing unit/integration tests. I hope they are alright.

I'm also not sure if my implementation of

tsigkey, err := pdns.TSIGKey.Change(ctx, "examplekey.", powerdns.TSIGKey{
	Key: powerdns.String("newkey"),
})

fits the general style.
Looking forward to your feedback. Any feedback is appreciated :)

@joeig joeig linked an issue Dec 23, 2023 that may be closed by this pull request
Copy link
Owner

@joeig joeig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Avarei, thanks for your contribution.

Looks good to me, just some minor typos or naming suggestions. Please rebase against main to fix an issue with two pipeline actions.

tsigkeys.go Outdated Show resolved Hide resolved
tsigkeys.go Outdated Show resolved Hide resolved
tsigkeys.go Outdated Show resolved Hide resolved
tsigkeys.go Outdated Show resolved Hide resolved
tsigkeys_test.go Outdated Show resolved Hide resolved
@Avarei
Copy link
Contributor Author

Avarei commented Dec 24, 2023

thank you for your feedback. I implemented it.

but appearantly I have a misunderstanding on how testing works.
I have to take a closer look on how to write the tests so they work with a mock server, as well as a real one reliably.

@Avarei
Copy link
Contributor Author

Avarei commented Dec 27, 2023

I made some adjustments to the tests and make test and make test-without-mocks are successful now.

@joeig joeig merged commit 687e6bc into joeig:main Dec 30, 2023
4 checks passed
@joeig
Copy link
Owner

joeig commented Dec 30, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for TSIG Keys
2 participants