-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TSIGKeys API #70
Add TSIGKeys API #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Avarei, thanks for your contribution.
Looks good to me, just some minor typos or naming suggestions. Please rebase against main
to fix an issue with two pipeline actions.
thank you for your feedback. I implemented it. but appearantly I have a misunderstanding on how testing works. |
I made some adjustments to the tests and |
Thanks! |
implements #69.
First time writing unit/integration tests. I hope they are alright.
I'm also not sure if my implementation of
fits the general style.
Looking forward to your feedback. Any feedback is appreciated :)