pkg/diff/run.go: reset worktree after loading packages #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After loading Go packages, the go.mod and go.sum files are sometimes modified. This causes subsequent checkouts of other commits to fail, which results in the command failing to produce API differences. This commit performs a hard reset on the worktree after the packages have been loaded so that subsequent checkouts succeed. This should be safe because go-apidiff checks to ensure that the tree is clean when the program starts.
|
Since you all helped get this added to CI for This solves some problems I've been having doing comparisons of other kubernetes libs (e.g. client-go) |
|
Should we make this opt-in? If folks run this locally with changes in the tree, we might overwrite their changes. |
|
@vincepri Before doing any moving around in the repo, we already check to make sure the tree is clean. That check should be forcing folks to have a clean tree before running this command. |
|
Makes sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After loading Go packages, the go.mod and go.sum files are sometimes modified.
This causes subsequent checkouts of other commits to fail, which results in
the command failing to produce API differences.
This commit performs a hard reset on the worktree after the packages have been
loaded so that subsequent checkouts succeed. This should be safe because
go-apidiff checks to ensure that the tree is clean when the program starts.