fix: handle repositories with symlinks targeting absolute paths #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joe Lanford joe.lanford@gmail.com
Workaround for go-git/go-git#253
When using
go-apidiffagainst the Helm repository, I was getting an error that the worktree was dirty even thoughgit statusreported it to be clean. Turns outgo-gitdoesn't correctly hash absolute symlinks due to the use of an abstracted filesystem and mangling of the symlink target.This PR works around this issue by adding and using a modified
billy.Filesystemimplementation that does not mangle symlink targets.