[6.x] fix auth when using a custom authentication pipeline in Fortify #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miguilimzero this should solve your issue |
joelbutcher
deleted the
fix/auth-with-fortify-authenticate-through-callback
branch
|
@joelbutcher I didn't have time to test it yet, but it looks like it will work seamlessly. Thank you for the prompt fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where, when using
Fortify::authenticateThroughin a service provider, the auth for Socialstream fails and kicks users out of the application (e.g. to the My Account page for Google OAuth).The problem is fixed by iterating over the pipes used by Fortify (or in the custom callback) and replacing Fortify's instances of
AttemptToAuthenticateandRedirectIfTwoFactorAuthenticatablewith our own.Resolves #378
Note
This does not solve the problem where developers create their own custom authentication implementations and don't use fortify's at all