Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Add remember session option #44

Merged
merged 4 commits into from
Jan 18, 2021
Merged

Conversation

miguilimzero
Copy link
Contributor

  • This pull request will add a config option in order to th developer enable remember option to socialstream sessions.

@miguilimzero
Copy link
Contributor Author

miguilimzero commented Jan 18, 2021

I also think that would be better if the env config get changed from 'SHOW_SOCIALSTREAM' to 'SOCIALSTREAM_DISPLAY' (or SOCIALSTREAM_SHOW), since the .env parameters always follow THETHING_THEPARAMETER format.

@joelbutcher joelbutcher self-assigned this Jan 18, 2021
@joelbutcher joelbutcher added the enhancement New feature or request label Jan 18, 2021
@joelbutcher joelbutcher changed the title Add remember session option [2.x] Add remember session option Jan 18, 2021
@joelbutcher
Copy link
Owner

I also think that would be better if the env config get changed from 'SHOW_SOCIALSTREAM' to 'SOCIALSTREAM_DISPLAY' (or SOCIALSTREAM_SHOW), since the .env parameters always follow THETHING_THEPARAMETER format.

@SrDante I agree with the format here. However, considering this would introduce a breaking change for those currently using 2.x, can you send this into master please?

@joelbutcher joelbutcher merged commit ce7e483 into joelbutcher:2.x Jan 18, 2021
@miguilimzero
Copy link
Contributor Author

I think that changing the env from SHOW_SOCIALSTREAM to SOCIALSTREAM_SHOW would not cause any break changes, since the configuration file would not be changed in published projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants