Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Feature: Create account on login #58

Merged
merged 5 commits into from
Jan 29, 2021

Conversation

joelbutcher
Copy link
Owner

This PR allows developers to choose whether or not user create an account from the login screen without having to go to /register.

This PR was inspired by #49, a great feature suggestion from @luiyongsheng. I was originally going to merge the branch in, but was conscious of adding another config item for developers to worry about. This PR resolves that worry by following the "features" pattern found in Laravel Jetstream and Fortify, becoming instantly familiar.

To enable the features simply add the following to your socialstream.php config file:

'features' => [
    \JoelButcher\Socialstream\Features::createAccountOnFirstLogin(),
]

@joelbutcher joelbutcher merged commit a30c6f1 into 2.x Jan 29, 2021
@joelbutcher joelbutcher deleted the features/account-creation-on-login branch January 29, 2021 17:32
@luiyongsheng
Copy link
Contributor

Kudos!

@joeelia
Copy link
Contributor

joeelia commented Feb 23, 2021

So just to confirm when users Signin AND Create an account in the same call then they loose the following settings from their profile:

  • Two Factor Authentication
  • Browser Sessions
  • Delete Account

I do not see these settings. It makes sense for the 2FA not being there but why were Browser Sessions and Delete Account removed?

@luiyongsheng
Copy link
Contributor

So just to confirm when users Signin AND Create an account in the same call then they loose the following settings from their profile:

  • Two Factor Authentication
  • Browser Sessions
  • Delete Account

I do not see these settings. It makes sense for the 2FA not being there but why were Browser Sessions and Delete Account removed?

Users need to setup password first in order to access those settings.

@joelbutcher
Copy link
Owner Author

So just to confirm when users Signin AND Create an account in the same call then they loose the following settings from their profile:

  • Two Factor Authentication

  • Browser Sessions

  • Delete Account

I do not see these settings. It makes sense for the 2FA not being there but why were Browser Sessions and Delete Account removed?

This is the correct functionality regardless of sign in. When you register via a provider, you don't have a password - the actions you've mentioned require a password confirmations. So setting a password will reveal these actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants