Improve parsing of node paths in references #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-prusov
force-pushed
the
path-fixes
branch
from
b10fd2b
to
1d292f6
Compare
joelspadin
reviewed
Oct 31, 2024
grammar.js
Outdated
| ), | ||
| path_in_tree: ($) => repeat1($.path_node), | ||
| _node_reference: ($) => seq('&{', alias($.path_in_tree, $.path), '}'), |
There was a problem hiding this comment.
I'm not sure I understand this part. Is there a reason that "path_in_tree" is being aliased to "path" instead of just being named "path" to begin with?
There was a problem hiding this comment.
My initial idea was to use a separate rule for paths to nodes to avoid potential overlap with paths in includes, but it seems like string_literal works fine there, so I removed this alias.
This change fixes handling of paths with unit addresses in the middle, i.e. path = <&/path@100/to@200/node>; Each path segment is represented by a separate node so grammar's users don't have to parse it manually.
igor-prusov
force-pushed
the
path-fixes
branch
from
1d292f6
to
f51b452
Compare
|
Looks good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes handling of paths with unit addresses in the middle,
i.e. path = <&/path@100/to@200/node>; Each path segment is represented
by a separate node so grammar's users don't have to parse it manually.
This fixes ~150 false positives on current Linux DTS files.