Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutable collections are causing race conditions #99

Open
knocte opened this issue May 22, 2020 · 2 comments
Open

Mutable collections are causing race conditions #99

knocte opened this issue May 22, 2020 · 2 comments

Comments

@knocte
Copy link
Collaborator

knocte commented May 22, 2020

See https://github.com/joemphilips/DotNetLightning/runs/695486967

(We should use Map instead of ConcurrentDictionary.)

@joemphilips
Copy link
Owner

I'm not 100% sure if the mutable collection is what causing this.
It may be something specific in Infrastructure tests. Anyway, #98 might be a solution if it is too hard to debug.

@knocte
Copy link
Collaborator Author

knocte commented May 22, 2020

I'd like to know Andrew's opinion on getting rid of Infrastructure project and tests before we nuke it. However, regardless of that, I think switching to immutable collections is still a worthy change.

joemphilips added a commit that referenced this issue Jun 9, 2020
* Infrastructure tests are fragile. And we don't have a
  plan to support it in the future.
  We will probably remove the whole code later.

* see
  * #98
  * #99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants