Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No mutable fields in message records #236

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

No mutable fields in message records #236

wants to merge 3 commits into from

Commits on Oct 12, 2022

  1. Core: changed return type Deserialize method 

    Made ILightningSerializable<'T>.Serialize method return
deserialized object instead of mutating `this` instance.
    @webwarrior-ws
    webwarrior-ws committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    8b57c03 View commit details
    Browse the repository at this point in the history

  2. Core: got rid of mutable fields 

    Removed `mutable` modifier from all record fields
    @webwarrior-ws
    webwarrior-ws committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    b8314c7 View commit details
    Browse the repository at this point in the history

  3. Core: added DummyInstanceHolder class 

    Added DummyInstanceHolder class for holding
ILightningSerializable<'T> instances used for deserialization.
Added comment describing why this workaround as well as
[<CLIMutable>] annotations on records are needed.
    @webwarrior-ws
    webwarrior-ws committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    99cec38 View commit details
    Browse the repository at this point in the history