Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added context path to javascipt sources and ajax request #4

Merged
merged 1 commit into from
Aug 8, 2014

Conversation

sachera
Copy link
Contributor

@sachera sachera commented Aug 6, 2014

Using relative paths leads to errors when using subdirectories. But switching back to absolute paths without adding the context path would revive Issue #2. As the context path needs to be known also when performing request from inside the angular module "lift-ng" it was made known through the global variable "net_liftmodules_ng.contextPath".

@joescii
Copy link
Owner

joescii commented Aug 6, 2014

Nice work, and great catch! Thanks for contributing it back. I'll cross check it in the next day or so with my projects and publish it ASAP.

@joescii joescii added the bug label Aug 6, 2014
@joescii joescii merged commit 7d951ac into joescii:master Aug 8, 2014
joescii added a commit that referenced this pull request Aug 8, 2014
joescii added a commit that referenced this pull request Aug 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants