fix: series fill & stroke being inconsistent for last data time < render time #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced in 86574e
No behavior changes
Reduce the amount of checks
This changes behavior a bit - when `render(` is passed a canvas different from `this.canvas`
|
This also made me think if we should add a |
WofWca
force-pushed
the
consistent-fill
branch
from
2ba907c to
6523aee
Compare
WofWca
changed the title
WofWca
force-pushed
the
consistent-fill
branch
from
d7cfd14 to
b805f93
Compare
…der time It would depend on `scrollBackwards` and `fillStyle` being `undefined` or not. Depending on this, it would either continue the line up to the edge of the canvas or leave it at `lastX`. This makes it so that it is always left at `lastX`.
WofWca
force-pushed
the
consistent-fill
branch
from
b805f93 to
fd47202
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would depend on
scrollBackwardsandfillStylebeingundefinedor not. Depending on this, it would either continue the line up to the edge of the canvas or leave it atlastX. This makes it so that it is always left atlastX.An example
Before:
After:
TODO:
render(),append()&updateTooltip()performance #135 or rebase.