Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips #73

Merged
merged 1 commit into from
Aug 25, 2017
Merged

Tooltips #73

merged 1 commit into from
Aug 25, 2017

Conversation

Sly1024
Copy link
Contributor

@Sly1024 Sly1024 commented May 15, 2016

image
Added configurable tooltips, because I needed them in my project: https://github.com/Sly1024/pigod.

Awesome charts, BTW!

@drewnoakes drewnoakes merged commit 67d135e into joewalnes:master Aug 25, 2017
drewnoakes added a commit that referenced this pull request Aug 25, 2017
Based largely on work by @Sly1024 in #73
@drewnoakes
Copy link
Collaborator

Very cool. Took a while to get to this, but I've fixed the conflicts and made a few tweaks such as:

  • updating the tooltip during rendering, so values update during scrolling even if the mouse isn't moving
  • deregistering mouse event handlers on stop()
  • allowing the tooltip option to be modified while the chart is running (for the builder)
  • updating the builder to allow playing with tooltips
  • move positioning offset to CSS
  • modifying format signature slightly, and specifying it fully in the .d.ts file
  • lightening the default tooltip vertical line colour
  • move binarySearch to Util

Thanks for the PR.

@drewnoakes
Copy link
Collaborator

Here's a screenshot from the builder:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants