Merge pull request nautobot#239 from nrnvgh/237/cable_creation_hanging

nautobot#237: when searching for cables, use pynautobot's filter() API to lim…
joewesch · Sep 6, 2023 · 07c0775 · 07c0775
2 parents 691f4c9 + 4328109
commit 07c0775
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/plugins/module_utils/dcim.py b/plugins/module_utils/dcim.py
@@ -142,14 +142,12 @@ def run(self):
             data["color"] = data["color"].lower()
 
         if self.endpoint == "cables":
-            cables = [
-                cable
-                for cable in nb_endpoint.all()
-                if cable.termination_a_type == data["termination_a_type"]
-                and cable.termination_a_id == data["termination_a_id"]
-                and cable.termination_b_type == data["termination_b_type"]
-                and cable.termination_b_id == data["termination_b_id"]
-            ]
+            cables = nb_endpoint.filter(
+                termination_a_type=data["termination_a_type"],
+                termination_a_id=data["termination_a_id"],
+                termination_b_type=data["termination_b_type"],
+                termination_b_id=data["termination_b_id"],
+            )
             if len(cables) == 0:
                 self.nb_object = None
             elif len(cables) == 1: