Update classy.pyx for cython v3.0.0+ #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! I'm back from leave now and will test it out. This is a bit fiddly as I will need to update the conda environment and doing either one first will break things for other people, so I'd like to do them at the same time. |
|
The test failure here is not associated with this PR, so I'll merge. Thanks so much! |
joezuntz
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cython version 3.0.0+ deprecated the use of cpdef for variables. This means that cosmosis-build-standard-library crashes with the newest versions of cython. This patch fixes the crash. It should also be backward compatible to earlier versions of cython, I think...