A_mod suppression of non-linear power #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joezuntz
requested changes
Oct 30, 2024
structure/amod/module.yaml
Outdated
| purpose: Modify the non-linear matter power spectrum using the A_mod phenomenological parameterization | ||
| url: "" | ||
| interface: amod.py | ||
| attribution: [] |
There was a problem hiding this comment.
Thanks so much for this contribution! You should definitely give yourself credit by adding your name to the attribution list!
structure/amod/module.yaml
Outdated
| " | ||
|
|
||
| # List of parameters that can go in the params.ini file in the section for this module | ||
| params: |
There was a problem hiding this comment.
This block should be replaced with:
params: {}
structure/amod/amod.py
Outdated
| A_mod = block["amod_parameter", "a_mod"] | ||
|
|
||
| # for now assume pk_lin and pk_nonlin are defined on the same grids | ||
| assert (block["matter_power_lin", "z"] == block["matter_power_nl", "z"]).all() |
There was a problem hiding this comment.
Could you replace these with this, just to give some more info to the user:
z_same = np.allclose(block["matter_power_lin", "z"], block["matter_power_nl", "z"])
k_same = np.allclose(block["matter_power_lin", "k_h"], block["matter_power_nl", "k_h"])
if not k_same and z_same:
raise ValueError("The redshift and k sampling of the linear and non-linear matter power must be the same to use the amod module")
|
Cool! I just added the suggested changes. |
joezuntz
approved these changes
Oct 31, 2024
|
Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very simple module to sample the phenomenological parameter A_mod from Amon & Efstathiou 2022.