Fix theta_H0_range usage by adding a key to dict #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be necessary for 'theta_H0_range' to be implemented correctly. The H0 values need to be a list for the dict entry `more_config['cosmology_params']['theta_H0_range']`, not for `more_config['cosmology_params']['theta_H0_range']`, otherwise you end up passing a list to camb.set_cosmology instead of keyword arguments.
|
Hi Mat, This looks great, thanks! Just to demonstrate it could you add the Cheers! |
This will ensure it gets run with the tests.
|
Done! |
joezuntz
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be necessary for 'theta_H0_range' to be implemented correctly. The H0 values need to be a list for the dict entry
more_config['cosmology_params']['theta_H0_range'], not formore_config['cosmology_params']['theta_H0_range'], otherwise you end up passing a list to camb.set_cosmology instead of keyword arguments.