Changes to project_2d.py to allow for different source bins #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing checks are conda-related, not to do with your changes. Let me fix them in main! |
|
Could you merge the main branch into this PR? I have added various fixes to the installation system that should hopefully fix these failures. |
|
Merged the main now, sorry for a silence. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... but not complete cross-correlations.
Motivation: if a passed power spectra is a cross-correlation between a tracer and a matter (for instance galaxy-galaxy lensing) then if the spectrum is passed for each lens bin separately, in most cases the underlying matter part will stay the same, thus can be correlated with a different tomographic bin for the source distribution.
This change hopefully accounts for that, but will still not allow the cross-correlations if the power spectrum is the auto-correlation in the first place. This should still also be ok for the IA and magnification cases.
Apart from this, the changes to allow for general clustering work perfectly. I can produce Cells for any power spectrum generated in this case using a HOD based halo model.