Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the janky sigma_8 sampling setup. Instead of running CAMB twice, the transfer function (which takes the most time) is only computed once and then the power spectra are recomputed using the correct A_s corresponding to the requested sigma_8.
This speeds things up by ~50% and also avoids the numerical uncertainty in the initial estimate of sigma_8 due to the low accuracy settings of the first run. Since
sigma_8_input
now agrees with the outputsigma_8
, I added the option of takingsigma_8
as the input directly. If bothsigma_8
andA_s
are provided,sigma_8
takes precedence.This approach could in principle be used to do fast sampling of all non-cosmology parameters, such as primordial power spectrum parameters in general or HMCode parameters. See for example cells 50 onward here: https://camb.readthedocs.io/en/latest/CAMBdemo.html