Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and apply scalafmt #26

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Add and apply scalafmt #26

merged 2 commits into from
Feb 17, 2022

Conversation

mdedetrich
Copy link
Contributor

@mdedetrich mdedetrich commented Feb 17, 2022 •
edited
Loading

Does the following

  1. Adds scalafmt and the sbt-scalafmt plugin
  2. Adds a github actions pipeline that uses scalafmt-native which can check that the entire project is formatted in ~5 seconds. It also runs concurrently to the main CDP build
  3. Applies scalafmt

In regards to the .scalafmt.conf configuration, I just used some generic configuration but if you want to use a different one than let me know and I can update and rebase it.

@mdedetrich mdedetrich force-pushed the add-and-apply-scalafmt branch from 904795c to f10a815 Compare February 17, 2022 10:43
johanandren
johanandren approved these changes Feb 17, 2022
View reviewed changes
Copy link
Owner

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@johanandren johanandren merged commit f0aa2c1 into johanandren:main Feb 17, 2022
@mdedetrich mdedetrich deleted the add-and-apply-scalafmt branch February 17, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanandren johanandren johanandren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdedetrich @johanandren