Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix check for non matching akka and akka http versions #10

Merged
merged 1 commit into from
May 24, 2024
Merged

Fix check for non matching akka and akka http versions #10

merged 1 commit into from
May 24, 2024

Conversation

Philippus
Copy link
Contributor

Applying this PR will fix the check for non-matching Akka and Akka HTTP versions:

  • the parameters were reversed (or they were reversed in the call to the method).
  • the scripted test threw an error, but for different reasons (Akka 2.4.26 doesn't exist).

johanandren
johanandren approved these changes May 24, 2024
View reviewed changes
Copy link
Owner

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@johanandren johanandren merged commit cfaae7e into johanandren:master May 24, 2024
3 checks passed
@Philippus Philippus deleted the fix-check-for-matching-akka-and-akka-http branch May 24, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanandren johanandren johanandren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Philippus @johanandren