Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to bevy 0.13 #10

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Update to bevy 0.13 #10

merged 3 commits into from
Feb 23, 2024

Conversation

TheNullicorn
Copy link
Contributor

Updates bevy, bevy_egui, and bevy_pancam dependencies for bevy 0.13.

Also fixes the asteroids example, whose shader was broken by bevy 0.13 rearranging bind groups.

Note: This is a draft because bevy_pancam doesn't yet support bevy 0.13, though bevy_pancam#56 will fix this. For the time being, I've swapped in that PR's github link for the bevy_pancam dependency.

- bevy: 0.12 -> 0.13
  - Move material data from bind group 1 to 2 in asteroid example (as per https://bevyengine.org/news/bevy-0-13/#wgpu-0-19-upgrade-and-rendering-performance-improvements)
- bevy_equi: 0.23 -> 0.25
- bevy_pancam: 0.10 -> 0.11 (waiting on bevy_pancam#56)

Signed-off-by: Nullicorn <git@nullicorn.me>
@johanhelsing
Copy link
Owner

Thanks for the fix and upgrade!

I've merged the pancam pr now.

I plan on doing releases on Thursday for most of my bevy crates

@johanhelsing
Copy link
Owner

bevy_pancam 0.11 is release now :)

@johanhelsing johanhelsing added the enhancement New feature or request label Feb 22, 2024
- Bevy 0.13 deprecated bevy_render::mesh::shape in favor of bevy_math::primitives
  - https://bevyengine.org/news/bevy-0-13/#primitive-shapes

Signed-off-by: Nullicorn <git@nullicorn.me>
- bevy_pancam: 0.10 -> 0.11
  - Now supports bevy 0.13

Signed-off-by: Nullicorn <git@nullicorn.me>
@TheNullicorn TheNullicorn marked this pull request as ready for review February 22, 2024 14:06
@TheNullicorn
Copy link
Contributor Author

Alright, I've updated it in Cargo.toml + caught a deprecation warning I missed earlier.

Copy link
Owner

@johanhelsing johanhelsing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!

This was referenced Feb 23, 2024
@@ -10,19 +10,18 @@ repository = "https://github.com/johanhelsing/noisy_bevy"
version = "0.5.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version = "0.6.0"

# bevy-inspector-egui = {version = "0.19.1", default-features = false}
bevy_pancam = { version = "0.10", features = ["bevy_egui"] }
bevy_egui = { version = "0.25", default-features = false, features = ["default_fonts"] }
bevy_pancam = { version = "0.11", features = ["bevy_egui"] }
insta = "1.21"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be safely upgrade to insta = "1.35"

@johanhelsing johanhelsing merged commit e6de99f into johanhelsing:main Feb 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants