Fix file selector in torrent details #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Astalfr, thanks a lot for creating a PR. This helped me to further debug the issue you linked. I landed on a slightly different solution which involves adding the index to the file object earlier and then only depending on that to ensure we always "talk" about the right file. I hope this makes sense, but feel free to ask questions or raise concerns. At least with my testing this solved the issue. |
johman10
added a commit
that referenced
this pull request
Nov 16, 2024
This PR aims to fix the issue described in #575. Sorting the file list before creating the folder structure could cause the file indices to be incorrect, leading to problems such as not downloading the correct file or folder. I tested it with a torrent where I encountered this problem and it seems to work properly with this patch. --------- Co-authored-by: Johan van Eck <johveck@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the issue described in #575.
Sorting the file list before creating the folder structure could cause the file indices to be incorrect, leading to problems such as not downloading the correct file or folder.
I tested it with a torrent where I encountered this problem and it seems to work properly with this patch.