Skip to content

Commit

Permalink
[CRUD] disable user change slices from dashboardmodelview (apache#5217)
Browse files Browse the repository at this point in the history
(cherry picked from commit 480ddfc)
  • Loading branch information
Grace Guo authored and John Bodley committed Jun 18, 2018
1 parent 475648e commit a602ce4
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions superset/views/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -537,9 +537,9 @@ class DashboardModelView(SupersetModelView, DeleteMixin): # noqa
list_columns = ['dashboard_link', 'creator', 'modified']
order_columns = ['modified']
edit_columns = [
'dashboard_title', 'slug', 'slices', 'owners', 'position_json', 'css',
'dashboard_title', 'slug', 'owners', 'position_json', 'css',
'json_metadata']
show_columns = edit_columns + ['table_names']
show_columns = edit_columns + ['table_names', 'slices']
search_columns = ('dashboard_title', 'slug', 'owners')
add_columns = edit_columns
base_order = ('changed_on', 'desc')
Expand All @@ -562,10 +562,6 @@ class DashboardModelView(SupersetModelView, DeleteMixin): # noqa
'owners': _('Owners is a list of users who can alter the dashboard.'),
}
base_filters = [['slice', DashboardFilter, lambda: []]]
add_form_query_rel_fields = {
'slices': [['slices', SliceFilter, None]],
}
edit_form_query_rel_fields = add_form_query_rel_fields
label_columns = {
'dashboard_link': _('Dashboard'),
'dashboard_title': _('Title'),
Expand Down

0 comments on commit a602ce4

Please sign in to comment.