Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type Stubs #189

Closed
kkirsche opened this issue Mar 4, 2020 · 3 comments · Fixed by #244
Closed

Type Stubs #189

kkirsche opened this issue Mar 4, 2020 · 3 comments · Fixed by #244
Labels
good first issue help wanted contributions welcome, submit a PR

Comments

@kkirsche
Copy link

kkirsche commented Mar 4, 2020

It would be awesome if the project could include type stubs for Python 3 to satisfy type check tools such as mypy
@floer32
Copy link
Collaborator

floer32 commented Mar 23, 2020

PRs welcome

@floer32 floer32 added good first issue help wanted contributions welcome, submit a PR labels Mar 23, 2020
@cdpierse
Copy link

cdpierse commented May 4, 2020

I'd be happy to have a go with this and add some type hinting.

@domdfcoding
Copy link

Hi @cdpierse, wondering whether you've made any progress with the type hints yet?

hauntsaninja pushed a commit to hauntsaninja/tldextract that referenced this issue Feb 4, 2022
Add types to the public API
3dff33c 
Resolves john-kurkowski#189
@hauntsaninja hauntsaninja mentioned this issue Feb 4, 2022
Merged
john-kurkowski pushed a commit that referenced this issue Feb 4, 2022
@hauntsaninja
Add types to the public API (#244)
40205f6 
Resolves #189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted contributions welcome, submit a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add types to the public API hauntsaninja/tldextract
4 participants
@kkirsche @floer32 @domdfcoding @cdpierse