Fix incorrect namespace used for caching function returns #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholas-plutoflume
changed the title
|
(Rebased) |
|
Thanks for the thorough PR and discussion! |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jun 16, 2022
https://build.opensuse.org/request/show/982862 by user mia + dimstar_suse - Update to 3.3.0 Features * Add CLI flag `--suffix_list_url` to set the suffix list URL(s) or source file(s) (#gh/john-kurkowski/tldextract#197) * Add CLI flag `--no_fallback_to_snapshot` to not fall back to the snapshot (#gh/john-kurkowski/tldextract#260) * Add alias `--include_psl_private_domains` for CLI flag `--private_domains` Bugfixes * Handle more internationalized domain name dots (#gh/john-kurkowski/tldextract#253) Misc. * Update bundled snapshot * Add basic CLI test coverage Changes in 3.2.1: Bugfixes * Fix incorrect namespace used for caching function returns (#gh/john-kurkowski/tldextract#258) Changes in 3.2.0: Features * Add types to the public API (#gh/john-kurkowski/tldextract#244) Bugfixes * Add support for Python 3.10, dr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #257.
Currently, the namespace is not passed to the function that sets the cache, and instead the literal "urls" is passed. As a result, non-url related functions, such as the function to cache the public suffixes were not cached.
This PR fixes this by using the
namespaceargument which is passed in to therun_and_cachefunction, and adds a regression test.