MenuApp, toggle display orientation, and format #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john0312
reviewed
Jul 21, 2024
| @@ -102,6 +107,16 @@ void display_get_frame_packed(display_buf_t *buf, int frame) { | |||
| break; | |||
| } | |||
|
|
|||
| if (display_orientation) { | |||
There was a problem hiding this comment.
This no longer works after Alex's change, you'll need to use display_buf_assign(), see examples above.
john0312
reviewed
Jul 21, 2024
| @@ -14,18 +14,18 @@ | |||
| * end: 1111111 (7*'1') | |||
| */ | |||
|
|
|||
| #define PACKET_START \ | |||
There was a problem hiding this comment.
Note that most of these are not used, see IrLogic.cc for more info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.