Fixes for foliate snap #1097
Merged
Fixes for foliate snap #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| stage-packages: | ||
| - libspeechd2 # probably necessary, need testing | ||
| prime: | ||
| - usr/lib/*/libspeechd.so.* |
There was a problem hiding this comment.
I don't think this is needed. It doesn't use libspeechd.
There was a problem hiding this comment.
Firefox snap also has it. And as mentioned, needs much more testing.
There was a problem hiding this comment.
Well, Firefox is probably using libspeechd, i.e. speech-dispatcher's official C client library. Foliate can't and doesn't use that. It has its own client implementation in GJS.
johnfactotum
pushed a commit
that referenced
this pull request
Nov 14, 2023
* added PKG_CONFIG_PATH for webkitgtk * added SPEECHD_ADRESS (copied from firefox) * added speechd to stage packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.