Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Compression and Set Protection #304

Merged
merged 8 commits into from
Sep 22, 2023
Merged

Set Compression and Set Protection #304

merged 8 commits into from
Sep 22, 2023

Conversation

johnfercher
Copy link
Owner

@johnfercher johnfercher commented Sep 22, 2023

Description

Related Issue

Checklist

check with "x", if applied to your change

  • All methods associated with structs has func (s *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Updated docs/doc.go
  • Updated pkg/pdf/example_test.go
  • Updated README.md
  • Updated all examples inside internal/examples
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint and goreportcard-cli

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 5.72% and project coverage change: -0.54% ⚠️

Comparison is base (7e0f178) 27.74% compared to head (49cd2f8) 27.20%.

❗ Current head 49cd2f8 differs from pull request most recent head 938130a. Consider uploading reports for the commit 938130a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##               v2     #304      +/-   ##
==========================================
- Coverage   27.74%   27.20%   -0.54%     
==========================================
  Files          17       17              
  Lines         786      809      +23     
==========================================
+ Hits          218      220       +2     
- Misses        564      585      +21     
  Partials        4        4              
Flag Coverage Δ
unittests 27.20% <5.72%> (-0.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/maroto.go 12.97% <0.00%> (-0.24%) ⬇️
pkg/metricsdecorator.go 0.00% <0.00%> (ø)
pkg/config/builder.go 86.07% <18.19%> (-6.72%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnfercher johnfercher changed the title keep Set Compression and Set Protection Sep 22, 2023
@johnfercher johnfercher marked this pull request as ready for review September 22, 2023 23:58
@johnfercher johnfercher merged commit 749bd2c into v2 Sep 22, 2023
@johnfercher johnfercher deleted the v2-set-password branch September 22, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant